PEP8

Question

jpf opened this issue 11 years ago · comments

What are your thoughts on PEP8?

I was thinking of updating your code to pass PEP8 checks (mostly to make my editor happy, since it does automatic PEP8 linting)

András Veres-Szentkirályi · Answer 1 · Tue Jun 18 2013 15:21:52 GMT+0800 (China Standard Time)

I agree with most of it, with the following clarifications

I have the following line in my ~/.pylintrc since I don't find these really important: disable=W0312,R0903,R0904,C0111,C0103,C0301
on the other hand, if you update the code to pass the tests, I'm happy to merge it :)

Joël Franusic · Answer 2 · Wed Jun 19 2013 06:03:52 GMT+0800 (China Standard Time)

Okay. I've updated the code to pass all the PEP8 checks, changes are in this branch: https://github.com/jpf/pySSTV/tree/pep8

(For what it's worth, all of the tests I wrote still pass)

András Veres-Szentkirályi · Answer 3 · Wed Jun 19 2013 16:27:58 GMT+0800 (China Standard Time)

Thanks for this too, I merged it, you can refetch from my tree, so that we have the same merge commit (0adf745) in our master branch.