[bug] Image comparaison issue

Question

[bug] Image comparaison issue

jsfez opened this issue 2 years ago · comments

Jeremy SFEZ commented 2 years ago

Hello Dmitriy,

Your project seems amazing and I would like to use it but I found an issue in image comparison.

It seems that odiff can't see the differences between this images.

Dmitriy Kovalenko · Answer 1 · Sat Dec 10 2022 19:04:30 GMT+0800 (China Standard Time)

Wow that is very unfortunate! Will take a look into this issue today

Jeremy SFEZ · Answer 2 · Sat Dec 10 2022 19:05:06 GMT+0800 (China Standard Time)

Thank a lot

Dmitriy Kovalenko · Answer 3 · Sat Dec 10 2022 19:39:33 GMT+0800 (China Standard Time)

In your case you should pass the -t 0 it looks like the algorithm that we are using treats these 2 colors very similar and the default threshold omits this from the diff

Jeremy SFEZ · Answer 4 · Sat Dec 10 2022 20:17:20 GMT+0800 (China Standard Time)

Thank you for your help and reactivity!
For archives, I set the threshold to 0.07.

Otherwise, I've seen that you have worked for Material UI. So you may have used Argos for automatic visual testing. We are working on a complete rework, and if the tests are conclusive, we will use Odiff instead of ImageMagick.