dmlc / gluon-nlp

NLP made easy

Home Page:https://nlp.gluon.ai/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Difference in naming convention between op.py and test_op.py

AetherPrior opened this issue · comments

Description

Mxnet's NumPy is being imported as np in the file src/gluonnlp/op.py:

from mxnet import np, npx

While NumPy is imported as np in test_op.py:

import numpy as np

This requires a change in conventions between tests and code, which can be a minor nuisance.

What have you tried to solve it?

  1. While a simple refactoring is possible, I don't want to be reverting any design decision in any way.