iPad & iPhone 5 support
jschwendt opened this issue · comments
Any chance of making this awesome control work with the iPad? Theoretically if we size things using AutoLayout, then we'd get both iPad and iPhone 5 support all in one shot.
Yeah I actually just added support for iPhone 5 but haven't committed.
Would just need to change to make the top and bottom bars extend all the
way across. I will do it once Internet is good here #sandy
Sweet!!! I you want me to give it a shot before committing, I'm happy to help test with my code base. I've been rather ham-stringed in the last two days as well (I'm in the Boston area but thankfully now have power and internet again).
Thanks,
Joe
Mind trying it out on the 5 now?
iPhone 5 generally looks good, but when the filters are displayed, I think there's some overlap in the reflection. iPad is much better, however the view only seems to support portrait as of now and the nav bar buttons need to be spread out evenly. Let me know if you want me to take a look at the code as well to help adjust accordingly and commit changes back.
Thanks,
Joe
@jschwendt could you post a screen shot from the 5 so I can see what you mean?
Here's a screenshot with the filters closed: http://postimage.org/image/o0y10ozdz/
Here's a screenshot with the filters shown: http://postimage.org/image/m2h49wxvb/
In the second picture, notice the transparent whitish line near the bottom of the preview image. I think it's just that the filter dock background is in the wrong vertical position.
@jschwendt yup. I see what I did. I just pushed a fix that should do it.
Way better! I think iPhone 5 is all set. Up for tackling iPad next? I'm going to give it a shot to enable AutoLayout and handle all of the layout with constraints to see if that tackles things better. Springs and Struts were not getting the job done.
I have AutoLayout working across 3.5" and 4" screen iPhones as well as iPads. I also started work enabling the whole UI to rotate, but that's proving to be a bit more difficult. How can I send you what I have thus far?
I'm closing this because I've added iPhone 5 support to the project and the image picker but don't care so much about the iPad version