Crash on IOS 5
adeelpervaiz opened this issue · comments
I just tried your code, it crashes on simulator(Running IOS 5) as well as iPhone 4(Running IOS 6).
Reproducing steps,
Select Photo Picker, select any photo from library, selected 3rd Filter,(First and second are working fine), or any other next filter will crash the app.
I think I found the problem, the method you called "initWithACV" should not pass the curve file name with extension.
so i repalced this code
-(void) setFilter:(int) index {
switch (index) {
case 1:{
filter = [[GPUImageContrastFilter alloc] init];
[(GPUImageContrastFilter *) filter setContrast:1.75];
} break;
case 2: {
filter = [[GPUImageToneCurveFilter alloc] initWithACV:@"crossprocess.acv"];
} break;
case 3: {
filter = [[GPUImageToneCurveFilter alloc] initWithACV:@"02.acv"];
} break;
case 4: {
filter = [[GrayscaleContrastFilter alloc] init];
} break;
case 5: {
filter = [[GPUImageToneCurveFilter alloc] initWithACV:@"17.acv"];
} break;
case 6: {
filter = [[GPUImageToneCurveFilter alloc] initWithACV:@"aqua.acv"];
} break;
case 7: {
filter = [[GPUImageToneCurveFilter alloc] initWithACV:@"yellow-red.acv"];
} break;
case 8: {
filter = [[GPUImageToneCurveFilter alloc] initWithACV:@"06.acv"];
} break;
case 9: {
filter = [[GPUImageToneCurveFilter alloc] initWithACV:@"purple-green.acv"];
} break;
default:
filter = [[GPUImageRGBFilter alloc] init];
break;
}
}
###############
REPLACED WITH THIS ONE.
-(void) setFilter:(int) index {
switch (index) {
case 1:{
filter = [[GPUImageContrastFilter alloc] init];
[(GPUImageContrastFilter *) filter setContrast:1.75];
} break;
case 2: {
filter = [[GPUImageToneCurveFilter alloc] initWithACV:@"crossprocess"];
} break;
case 3: {
filter = [[GPUImageToneCurveFilter alloc] initWithACV:@"02"];
} break;
case 4: {
filter = [[GrayscaleContrastFilter alloc] init];
} break;
case 5: {
filter = [[GPUImageToneCurveFilter alloc] initWithACV:@"17"];
} break;
case 6: {
filter = [[GPUImageToneCurveFilter alloc] initWithACV:@"aqua"];
} break;
case 7: {
filter = [[GPUImageToneCurveFilter alloc] initWithACV:@"yellow-red"];
} break;
case 8: {
filter = [[GPUImageToneCurveFilter alloc] initWithACV:@"06"];
} break;
case 9: {
filter = [[GPUImageToneCurveFilter alloc] initWithACV:@"purple-green"];
} break;
default:
filter = [[GPUImageRGBFilter alloc] init];
break;
}
}
Now its working fin.
Thanks. The code works with the GPUImage I've included, but I imagine this fixed the updates to the latest version.
Just updated the code. Thanks for the catch.
