dlang-tour / core

D Language online tour (https://tour.dlang.org/) and online editor (https://run.dlang.io/)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Wrong syntax highlight / indentation for nestable multi line comments

Geod24 opened this issue · comments

// Single line
/* Multi
Line
Comment
*/
/+ Nestabled
/+
Multi
/+
Line
+/ Comment +/ +/
    void main () {}

Looks like the issue is present on Github as well... So I guess it's @jacob-carlborg 's territory ?

Screen Shot 2020-10-30 at 14 50 27

I can reproduce it in TextMate as well. I created an issue in the D bundle repository: textmate/d.tmbundle#20. I'll take a look when I have some time.

Fixed in the TextMate bundle: textmate/d.tmbundle#20. I don't know how the procedure for updating the bundle used by GitHub works.

Fixed in the TextMate bundle: textmate/d.tmbundle#20. I don't know how the procedure for updating the bundle used by GitHub works.

https://github.com/github/linguist/blob/master/CONTRIBUTING.md#fixing-syntax-highlighting
https://github.com/github/linguist/tree/master/vendor

Last update was in June though: github-linguist/linguist#4881

Regarding Github, we might be lucky: github-linguist/linguist#5084 :)

Regarding Github, we might be lucky: github/linguist#5084 :)

You definitely will be. 😁

This is the change from the grammar that will be pulled in in this next Linguist release which looks to include the changes in textmate/d.tmbundle#20

Oops, we broke something 💥

/++
 Someone's having a bad time
+/
void myFunction () {}

Oops, we broke something 💥

My bad, should be fixed in: textmate/d.tmbundle@e031d03.