Optimization needed

Question

Optimization needed

dkk opened this issue 3 years ago · comments

When drawing many items, for example with something like:

WrappingHStack(1...50) {
    Text("Item: \($0)")
}

it takes way too long to draw.

Scott Ostler · Answer 1 · Tue Jul 13 2021 06:38:57 GMT+0800 (China Standard Time)

@dkk one optimization I found helpful was to store the result of InternalWrappingHStack.firstItemOfEachLane so it's only computed once – that made the difference in being able to use this for an interactive UI with about 20 items

if you'd like I can open a PR, it's a very small change: scottostler@4c74430

thanks for providing this library btw, it was just what I needed for a collection of pill buttons

Daniel Klöck · Answer 2 · Sun Jul 18 2021 19:16:18 GMT+0800 (China Standard Time)

Thanks a lot. Yes, please open that PR. I'm on holidays right now, but I'll try it out as soon as I'm back.

Daniel Klöck · Answer 3 · Wed Jul 28 2021 20:37:57 GMT+0800 (China Standard Time)

Included in release 2.1.2. I'm leaving this issue open since I still would like to write performance tests & maybe take a look if I can improve WrappingHSTack some more.

Daniel Klöck · Answer 4 · Sat Dec 03 2022 22:00:13 GMT+0800 (China Standard Time)

Fixed at version 2.2.8