Are you open to adding more color/theme to the project?

Question

Are you open to adding more color/theme to the project?

burinc opened this issue 3 years ago · comments

I just want to check before opening a new PR.

Chris Badahdah · Answer 1 · Sat Oct 16 2021 08:22:42 GMT+0800 (China Standard Time)

Hi @burinc, I'm definitely open to adding more themes, especially if they are among the more established color themes in the programming community. The alternative is finally allowing users to specify their own themes via options. What theme are you thinking about adding?

Burin · Answer 2 · Sat Oct 16 2021 08:39:18 GMT+0800 (China Standard Time)

I really like this theme.
It is very similar to nord but for me it is more readable.

https://github.com/NicolasPetton/zerodark-theme

And how do I test this locally before I submit the PR?

Burin · Answer 3 · Sat Oct 16 2021 08:42:36 GMT+0800 (China Standard Time)

Sample screenshot when using it in Emacs

Burin · Answer 4 · Sat Oct 16 2021 08:44:22 GMT+0800 (China Standard Time)

Compare this with nord

Chris Badahdah · Answer 5 · Sat Oct 16 2021 09:04:14 GMT+0800 (China Standard Time)

That theme looks very nice 😍! There is a development section in the readme. Mainly, run bb dev to get a shadow-cljs server running. Connect via nrepl/socket repl and start evaling stuff in user.clj.

Burin · Answer 6 · Sat Oct 16 2021 09:07:22 GMT+0800 (China Standard Time)

Cool, I will give this a try this weekend.
Thanks

Burin · Answer 7 · Sun Oct 17 2021 09:00:09 GMT+0800 (China Standard Time)

See PR #72 for details.

Burin · Answer 8 · Mon Oct 18 2021 08:05:20 GMT+0800 (China Standard Time)

Closed since PR #72 is now in the master branch.