Bug: CIF spanish starting with U does not validate
Vargax01 opened this issue · comments
Hello,
django-localflavor ES does not validate the cif that begin with U. I have been analyzing the code and I have seen that the U is not within the list of values of the cif.
self.cif_types = 'ABCDEFGHJKLMNPQRSVW'
The cif that begin with U are totally valid (https://es.wikipedia.org/wiki/C%C3%B3digo_de_identificaci%C3%B3n_fiscal)
Could you tell me what to do to fix this.
Thanks greetings
Hi, Thanks for the bug report. The best thing to do is submit a PR with the fix and passing test demonstrates that the issue is fixed. Thanks.
Hey @Vargax01 you could fork it and clone this repo in your pc and redirect to ES localflavour and you could alter the cif_types and run the tox if all tests get passed send a PR. If you face any difficulties just put a message
Hi,
Yes I solve the problem, I edit the code in the forms.py file and change the line to this line:
self.cif_types = 'ABCDEFGHJKLMNPQRSUVW'
And everything works perfectly.
I hope you can implement the updated cif letters in future versions
Thanks greetings
Hi,
Yes I solve the problem, I edit the code in the forms.py file and change the line to this line:
self.cif_types = 'ABCDEFGHJKLMNPQRSUVW'
And everything works perfectly.
I hope you can implement the updated cif letters in future versionsThanks greetings
You need to create a PR to get your code merged
Fixed in #469