django / django-localflavor

Country-specific Django helpers, formerly of contrib fame

Home Page:https://django-localflavor.readthedocs.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Fix style warnings and enable build failures for violating the style

Dunedan opened this issue · comments

#212 enabled style checking via prospector. This style checking is currently also done automatically via TravisCI for every new commit, but because of the number of current style violations failing the build because of style violations is disabled via passing the --zero-exit parameter to prospector.

After all style warnings got fixed enabling build failures for new style violations would be an option.

Styling errors that were not fixed, and marked with # noqa:

refactor complex methods

localflavor/id_/forms.py
Line: 111
mccabe: MC0001 / IDLicensePlateField.clean is too complex (12)

localflavor/no/forms.py
Line: 46
mccabe: MC0001 / NOSocialSecurityNumber.clean is too complex (13)

depricate non pep8 complient names

localflavor/sg/forms.py
Line: 62
pep8: N801 / class names should use CapWords convention (col 7)