Admin class is sometimes not registered (1.7.2 regression)

Question

Admin class is sometimes not registered (1.7.2 regression)

czpython opened this issue 8 years ago · comments

Hello,

The following commit e51cbd9 introduced a regression in regards to the admin.

This line:

Klass._meta.app_label is "django_comments"

assumes that both strings share the same memory id, which is true in certain cases (usually inside a REPL):

>>> id("django_comments")
4315523368
>>> id("django_comments")
4315523368
>>> id("django_comments")
4315523368

But when executing this in a script, the ids are different.

So currently Klass._meta.app_label is "django_comments" returns False even though both strings are 'django_comments'.

James Addison · Answer 1 · Tue Sep 13 2016 03:21:54 GMT+0800 (China Standard Time)

@claudep, can we get a new release with this fix? I have a feeling it's behind a few issues out in the wild (I know it's causing issues in my project).

Claude Paroz · Answer 2 · Tue Sep 13 2016 03:23:46 GMT+0800 (China Standard Time)

Sure, it's definitely on my TODO for this week.

Claude Paroz · Answer 3 · Wed Sep 14 2016 01:53:16 GMT+0800 (China Standard Time)

1.7.3 is out, https://pypi.python.org/pypi/django-contrib-comments

James Addison · Answer 4 · Thu Sep 15 2016 10:22:04 GMT+0800 (China Standard Time)

Awesome, thanks!

On Sep 13, 2016 10:53 AM, "Claude Paroz" notifications@github.com wrote:

1.7.3 is out, https://pypi.python.org/pypi/django-contrib-comments

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#95 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGLHJ8HrUQErQllVBndjZauWrRI9ZaEks5qpuMNgaJpZM4JctLL
.