Converting post_comment to Class Based views

Question

Converting post_comment to Class Based views

SudShekhar opened this issue 8 years ago · comments

Hi,

I was just wondering if there are any plans to migrate post_comment function to class based views? I am customizing django-contrib-comments to allow for file uploads and will need to copy paste the whole function. Was thinking that it would be much easier if we had the same thing as a class.

Any particular reason why it has not been done yet? Will pull requests for the same be welcome?

Thanks!

Claude Paroz · Answer 1 · Sun Apr 17 2016 20:16:41 GMT+0800 (China Standard Time)

I also think that converting it to a class-based view would add value. So yes, patch welcome!

Sudhanshu Shekhar · Answer 2 · Mon Apr 18 2016 12:40:37 GMT+0800 (China Standard Time)

Cool. I will try to write the new view and create a patch over the coming weekend.

Thomas Leichtfuß · Answer 3 · Wed Jul 14 2021 01:12:16 GMT+0800 (China Standard Time)

Just added a pull request #170 . A class based view would make customizing the view a lot more straight forward.