django / django-asv

Benchmarks for Django using asv

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Build up history for new benchmarks

smithdc1 opened this issue · comments

Hi @deepakdinesh1123

https://smithdc1.github.io/django-asv/ the website looks great with new results being added yesterday.

One thought is that when we're adding new benchmarks can we build up some history by running against the list of commits that you had? The aim being to build up a trend line?

image

What do you think?

Hi @smithdc1

Should I also add the history for python versions 3.8 and 3.9 for all the benchmarks? If yes, I think it might be better to add them as a separate PR.

That sounds good, if possible.

Separate prs sounds good too.

We will need to think about maintainability going forward. That is, how do we add and remove python versions. Does it "just work" (tm) or is there something that will cause issues?

Since miniconda is being used by ASV adding or removing python versions does not cause any problems, but adding versions of python that are not supported by the version of Django being benchmarked causes the benchmarks to fail but this won't be a problem since --strict option is not used when building results history.