django / django-asv

Benchmarks for Django using asv

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

django branch master renamed to main, needs to be accomodated

muskanvaswan opened this issue · comments

As of March 9, 2021, Django renamed its master branch to main.
Here is the link to the conversation and announcement in the mailing list

This is causing a variety of errors while run asv commands. Defaults for git commands etc need to be changed to fix this.

Thanks for the report.

Would you like to have a go at fixing this? I think it should be a matter of finding the right setting in the JSON file?

I did try that, however, for some reason, it continues to flash the same errors saying unknown branch master in configuration. I even went so far as to do a full-text search on the entire project for master and replace it with main, it continues to flash the same error still.
On looking into it further I think this is a default setting from airspeed velocity itself and we might have to wait on them to fix it. Not sure if there is a better solution to this. I faced pretty much the same issue with djangobench, because of the renaming as I was trying this out for GSoC.
any ideas on what could be done about this?

Yes, I did.

Hmm. Interesting.

I had a look at the asv issues and couldn't see anything relevant there.

I'll try and have a look, it's been a while since I've looked at this properly.

Thanks for your efforts here! 👍

Fixed in a065f1d

@muskanvaswan -- do you want to have another look at this?

turns out, the reason that fix wasn't working for me was that it didn't recognise the change in the asv.conf.file. Deleting the cache folder did the trick eventually