django-oscar / django-oscar

Domain-driven e-commerce for Django

Home Page:http://oscarcommerce.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

A voucher offer is alway saved as a site offer

kevinrenskers opened this issue · comments

Issue Summary

Whenever I want to create or edit a voucher offer, it is always saved as a site offer.

Steps to Reproduce

Whenever I create a new voucher offer, it actually gets saved as a site offer, when I press save on step 4.

  1. Create a new voucher offer:

Screenshot 2023-08-07 at 17 25 02

  1. On step 4 its type is still "Voucher":

Screenshot 2023-08-07 at 17 25 48

  1. But when saving, the type changes to "Site offer".

Screenshot 2023-08-07 at 17 25 55

The only way to make it into a Voucher offer is to edit this offer in the database, I can't do it via the dashboard at all. Editing a voucher offer also turns it into a site offer upon saving.

On the Oscar sandbox site it does work. The biggest difference I can spot is that I have 3 offer types:

Screenshot 2023-08-07 at 17 29 14

But the sandbox only has two:

Screenshot 2023-08-07 at 17 30 03

Technical details

  • Python version: 3.10.
  • Django version: 3.2.20.
  • Oscar version: 3.2.

Hi @kevinrenskers ,

I added User specific offer in sandbox.
OSCAR_OFFERS_IMPLEMENTED_TYPES = [ "SITE", "VOUCHER", "USER" ]

But the offer type didn't change when I followed your steps to reproduce. Kindly let us know any other details that could help us reproduce this issue.

Thanks.

Yeah I also mentioned that it works fine on the sandbox, and I don't know what other details to give since it's not reproducible on the sandbox. I have no clue why this is happening in my version.

The biggest difference is that I see 3 offer types, and in the sandbox I only see 2. What could cause that to happen?

While testing this, I added User specific offer in sandbox too, as mentioned earlier. Hence, the difference of 3 or 2 offer types isn't what's causing this. Is there any other change you made in the offer views?

image

I don't think so, no. I really have no idea what's going on.

But we're in the process of migrating away from Oscar to a custom-built store, so feel free to close this issue since it's not reproducible and I seem to be the only one with this problem.