django-oscar / django-oscar

Domain-driven e-commerce for Django

Home Page:http://oscarcommerce.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Voucher offer is only applied to one single product in the basket

kevinrenskers opened this issue · comments

Issue Summary

When creating a voucher offer without "max affected items" set, it is still only applied to one single item in the basket.

Steps to Reproduce

I used the sandbox (https://latest.oscarcommerce.com/en-gb/dashboard) to create a new Voucher Offer that applied to all items, gives a $2 discount, and doesn't set a max affected items value.

Screenshot 2023-08-07 at 17 15 13

I then created a voucher set with some vouchers. I added some items to my cart, and applied one of the vouchers.

The problem is that the total discount is only $2, whereas I would expect it to be $2 per item? After all, I didn't set "max affected items" to 1.

Screenshot 2023-08-07 at 17 15 23

Technical details

  • Python version: 3.10.
  • Django version: 3.2.20.
  • Oscar version: 3.2.

This benefit's description was a bit misleading, I have updated the description here #3954. The discount is applied on the basket's total instead of applying on each product price.