djangocms-admin-style #nav-sidebar styles unreadable in dark mode

Question

djangocms-admin-style #nav-sidebar styles unreadable in dark mode

worthwhile-gwarner opened this issue 3 years ago · comments

Description

Tested on Win 11 and macOS 11.6 in Firefox 95.0b4 and Edge 95.0.1020.44. Logging into Django admin and accessing a Pages section reveals the #nav-sidebar element and its child tr tags to be set with a background-color of var(--body-bg), which inherits from base.css in Django admin (Django 3.2.6) where @meda (prefers-color-scheme: dark) sets the body bg to off-black. However no other surrounding admin bg styles are set similarly, and foreground is not set to a corresponding light color, leaving the text unreadable unless switching to a system light mode theme.

Steps to reproduce

Sign in to Django CMS admin with a dark system theme set on Win or Mac
Click Pages section

Expected behaviour

Expect either the admin interface overall will favor dark theme and set corresponding foreground colors for sufficient contrast, or preserve a light background for now to maintain legibility.

Actual behaviour

Nav sidebar links in Django CMS Admin when using system dark mode are illegible.

Screenshots

Additional information (CMS/Python/Django versions)

Django CMS 3.9.0
Python 3.6.9
Django 3.2.6

Do you want to help fix this issue?

Yes, I want to help fix this issue and I will join #workgroup-pr-review on Slack to confirm with the community that a PR is welcome.
No, I only want to report the issue.

Simon Krull · Answer 1 · Tue Nov 09 2021 02:55:09 GMT+0800 (China Standard Time)

Hello @worthwhile-gwarner !

Thanks a lot, for creating the issue! And welcome, to the django CMS project :)

I will move your issue to the djangocms-admin-style repository. Because this Issue is related to the djangocms-admin-style package.

Gregory Warner · Answer 2 · Tue Nov 09 2021 03:11:41 GMT+0800 (China Standard Time)

Ah, thank you @crydotsnake! 🙂 Apologies!

Simon Krull · Answer 3 · Tue Nov 09 2021 03:34:02 GMT+0800 (China Standard Time)

No problem ! 🙂

What is your version of the djangocms-admin-style package? Because I cannot reproduce the bug.

Gregory Warner · Answer 4 · Tue Nov 09 2021 03:43:01 GMT+0800 (China Standard Time)

Current version in my piplock file is 2.0.2.

Sorry this appears to be a duplicate then of this outstanding issue: #438

Simon Krull · Answer 5 · Tue Nov 09 2021 03:52:11 GMT+0800 (China Standard Time)

Okay, the same version that I use :)

Thanks anywhere for reporting it!

Mark Walker · Answer 6 · Tue Nov 09 2021 04:28:08 GMT+0800 (China Standard Time)

I think the dark mode came in with django 3.2.

The app hasn't been updated since some work for django 3.1 so it needs work to support the dark theme.

This is essentially the same as #438

Fabian Braun · Answer 7 · Tue Mar 08 2022 03:51:44 GMT+0800 (China Standard Time)

This will be solved by #443

Fabian Braun · Answer 8 · Tue Apr 05 2022 17:41:48 GMT+0800 (China Standard Time)

@worthwhile-gwarner Dark mode works in version 3.1.