django-cms / djangocms-admin-style

django CMS Admin Style is a Django Theme tailored to the needs of django CMS.

Home Page:http://www.django-cms.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

compatibility with django-constance

sobolevn opened this issue · comments

I have found a small issue with django-constance.

Here's how it looks now:
2017-04-20 22 49 44

It all happens because of these lines:

.change-list #changelist table tbody td, .change-list #changelist table tbody th {
  white-space: nowrap;
}

If I change it to:

.change-list #changelist table tbody td, .change-list #changelist table tbody th {
  white-space: normal;  /* some others work too */
}

It all starts to work fine:
2017-04-20 22 52 27

I am using these versions:

django-cms==3.4.2
django-constance[database]==2.0.0
djangocms-admin-style==1.2.6.2 # via django-cms

@sobolevn thanks for the report. Would you be able to post the generated HTML by the application and targeted node where the issue occurs so we can apply a specific fix for django-constance?

Sorry, I don't get the part with the node. What is node in this context?
No problems with html though.

@sobolevn the styling issue occurs on the following HTML-Node:

.change-list #changelist table tbody td, .change-list #changelist table tbody th

we need to target this specifically, as changing the no-wrap behaviour might affect other admin parts (as it's a huge beast), so we would need something like:

.change-list #changelist .django_constance td.constance, .change-list #changelist .django_constance th.constance

So while you provide the generated HTML, I need to know where the targeted node (td.constance, th.constance) is to generate a specific fix for it.

@sobolevn I'm not seeing the <tbody> there, is there something being done via javascript?

I will check later.

@sobolevn are you able to paste those generated HTML? (is quite old issue but maybe you fixed this or still have this issue waiting to resolve).