django-cms / django-sekizai

Django Template Blocks with extra functionality

Home Page:https://django-sekizai.readthedocs.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

tests missing from pypi sdist

dvzrv opened this issue · comments

Hi! I'm packaging django-sekizai for Arch Linux. We usually use pypi.org for tracking upstreams and downloading source tarballs to build.

Currently I'm unable to run tests, because they are not added in the source tarball. According to upstream documenation, the MANIFEST.in should correctly add the tests for this project though.

After running python setup.py sdist on the current version (1.1.0) from git, I get an sdist tarball with the following:

drwxr-xr-x dave/dave         0 2020-01-23 10:35 django-sekizai-1.1.0/
-rw-r--r-- dave/dave       295 2020-01-23 10:35 django-sekizai-1.1.0/.coveragerc
-rw-r--r-- dave/dave       426 2020-01-23 10:35 django-sekizai-1.1.0/.editorconfig
-rw-r--r-- dave/dave       175 2020-01-23 10:35 django-sekizai-1.1.0/.gitignore
-rw-r--r-- dave/dave      1363 2020-01-23 10:35 django-sekizai-1.1.0/.travis.yml
-rw-r--r-- dave/dave       642 2020-01-23 10:35 django-sekizai-1.1.0/CHANGELOG.rst
-rw-r--r-- dave/dave      1486 2020-01-23 10:35 django-sekizai-1.1.0/LICENSE.txt
-rw-r--r-- dave/dave        68 2020-01-23 10:35 django-sekizai-1.1.0/MANIFEST.in
-rw-r--r-- dave/dave      4369 2020-01-23 10:35 django-sekizai-1.1.0/PKG-INFO
-rw-r--r-- dave/dave      2541 2020-01-23 10:35 django-sekizai-1.1.0/README.rst
drwxr-xr-x dave/dave         0 2020-01-23 10:35 django-sekizai-1.1.0/django_sekizai.egg-info/
-rw-r--r-- dave/dave      4369 2020-01-23 10:35 django-sekizai-1.1.0/django_sekizai.egg-info/PKG-INFO
-rw-r--r-- dave/dave      1842 2020-01-23 10:35 django-sekizai-1.1.0/django_sekizai.egg-info/SOURCES.txt
-rw-r--r-- dave/dave         1 2020-01-23 10:35 django-sekizai-1.1.0/django_sekizai.egg-info/dependency_links.txt
-rw-r--r-- dave/dave         1 2020-01-23 10:35 django-sekizai-1.1.0/django_sekizai.egg-info/not-zip-safe
-rw-r--r-- dave/dave        43 2020-01-23 10:35 django-sekizai-1.1.0/django_sekizai.egg-info/requires.txt
-rw-r--r-- dave/dave         8 2020-01-23 10:35 django-sekizai-1.1.0/django_sekizai.egg-info/top_level.txt
drwxr-xr-x dave/dave         0 2020-01-23 10:35 django-sekizai-1.1.0/docs/
-rw-r--r-- dave/dave      3142 2020-01-23 10:35 django-sekizai-1.1.0/docs/Makefile
-rw-r--r-- dave/dave      6335 2020-01-23 10:35 django-sekizai-1.1.0/docs/conf.py
-rw-r--r-- dave/dave     13233 2020-01-23 10:35 django-sekizai-1.1.0/docs/index.rst
drwxr-xr-x dave/dave         0 2020-01-23 10:35 django-sekizai-1.1.0/sekizai/
-rw-r--r-- dave/dave        46 2020-01-23 10:35 django-sekizai-1.1.0/sekizai/__init__.py
-rw-r--r-- dave/dave       400 2020-01-23 10:35 django-sekizai-1.1.0/sekizai/context.py
-rw-r--r-- dave/dave       350 2020-01-23 10:35 django-sekizai-1.1.0/sekizai/context_processors.py
-rw-r--r-- dave/dave       216 2020-01-23 10:35 django-sekizai-1.1.0/sekizai/context_processors.pyi
-rw-r--r-- dave/dave       725 2020-01-23 10:35 django-sekizai-1.1.0/sekizai/data.py
-rw-r--r-- dave/dave      5378 2020-01-23 10:35 django-sekizai-1.1.0/sekizai/helpers.py
-rw-r--r-- dave/dave       807 2020-01-23 10:35 django-sekizai-1.1.0/sekizai/helpers.pyi
-rw-r--r-- dave/dave        24 2020-01-23 10:35 django-sekizai-1.1.0/sekizai/models.py
drwxr-xr-x dave/dave         0 2020-01-23 10:35 django-sekizai-1.1.0/sekizai/templatetags/
-rw-r--r-- dave/dave        24 2020-01-23 10:35 django-sekizai-1.1.0/sekizai/templatetags/__init__.py
-rw-r--r-- dave/dave      4589 2020-01-23 10:35 django-sekizai-1.1.0/sekizai/templatetags/sekizai_tags.py
-rw-r--r-- dave/dave       203 2020-01-23 10:35 django-sekizai-1.1.0/sekizai/templatetags/sekizai_tags.pyi
-rw-r--r-- dave/dave        38 2020-01-23 10:35 django-sekizai-1.1.0/setup.cfg
-rw-r--r-- dave/dave      1661 2020-01-23 10:35 django-sekizai-1.1.0/setup.py
drwxr-xr-x dave/dave         0 2020-01-23 10:35 django-sekizai-1.1.0/tests/
-rw-r--r-- dave/dave        24 2020-01-23 10:35 django-sekizai-1.1.0/tests/__init__.py
-rw-r--r-- dave/dave        39 2020-01-23 10:35 django-sekizai-1.1.0/tests/requirements.txt
-rw-r--r-- dave/dave      1304 2020-01-23 10:35 django-sekizai-1.1.0/tests/settings.py
drwxr-xr-x dave/dave         0 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/
-rw-r--r-- dave/dave       228 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/basic.html
-rw-r--r-- dave/dave       161 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/css.html
-rw-r--r-- dave/dave       260 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/css2.html
-rw-r--r-- dave/dave        88 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/easy_base.html
-rw-r--r-- dave/dave        79 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/easy_inherit.html
-rw-r--r-- dave/dave        90 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/eat.html
drwxr-xr-x dave/dave         0 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/errors/
-rw-r--r-- dave/dave        70 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/errors/failadd.html
-rw-r--r-- dave/dave       137 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/errors/failbase.html
-rw-r--r-- dave/dave       137 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/errors/failbase2.html
-rw-r--r-- dave/dave        74 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/errors/failinc.html
-rw-r--r-- dave/dave        43 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/errors/failrender.html
drwxr-xr-x dave/dave         0 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/inherit/
-rw-r--r-- dave/dave       336 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/inherit/base.html
-rw-r--r-- dave/dave        90 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/inherit/baseinc.html
-rw-r--r-- dave/dave       105 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/inherit/chain.html
-rw-r--r-- dave/dave       193 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/inherit/extend.html
-rw-r--r-- dave/dave        32 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/inherit/extinc.html
-rw-r--r-- dave/dave         0 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/inherit/nullbase.html
-rw-r--r-- dave/dave        87 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/inherit/nullext.html
-rw-r--r-- dave/dave        39 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/inherit/spacechain.html
-rw-r--r-- dave/dave        37 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/inherit/subvarchain.html
-rw-r--r-- dave/dave       248 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/inherit/super_blocks.html
-rw-r--r-- dave/dave        19 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/inherit/varchain.html
-rw-r--r-- dave/dave       122 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/named_end.html
-rw-r--r-- dave/dave       248 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/namespaces.html
drwxr-xr-x dave/dave         0 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/processors/
-rw-r--r-- dave/dave       170 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/processors/addtoblock_namespace.html
-rw-r--r-- dave/dave       165 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/processors/addtoblock_null.html
-rw-r--r-- dave/dave       171 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/processors/namespace.html
-rw-r--r-- dave/dave       166 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/processors/null.html
-rw-r--r-- dave/dave       166 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/unique.html
-rw-r--r-- dave/dave       251 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/variables.html
-rw-r--r-- dave/dave       169 2020-01-23 10:35 django-sekizai-1.1.0/tests/templates/with_data.html
-rw-r--r-- dave/dave     14672 2020-01-23 10:35 django-sekizai-1.1.0/tests/test_core.py
-rw-r--r-- dave/dave      1116 2020-01-23 10:35 django-sekizai-1.1.0/tox.ini

How was the sdist tarball on pypi.org created and is there a particular reason to seemingly specifically remove the tests from a source release?

I would like to be able to verify the integration of this package with the rest of the system and be able to report problems as soon as possible and I'm sure others would like that, too.
Not having tests sort of defies the purpose of a source tarball.

@dvzrv the tests have been excluded through https://github.com/divio/django-sekizai/blob/master/setup.py#L51 which has been requested in the past by the community (the tarball should ideally hold only production code). I'm not aware of use cases integrating them but I'm happy to learn one :)

@dvzrv tests will be included in the next build

@FinalAngel Thanks for getting back on this. Sorry, I have been on holidays and been a bit busy in the past month.

The tests are unfortunately not yet included in the pypi sdist:

pypi tarball 2.0.0:

drwxr-xr-x finalangel/staff  0 2020-08-26 11:22 django-sekizai-2.0.0/
-rw-r--r-- finalangel/staff 1486 2020-08-06 09:39 django-sekizai-2.0.0/LICENSE.txt
-rw-r--r-- finalangel/staff   68 2020-08-06 09:39 django-sekizai-2.0.0/MANIFEST.in
-rw-r--r-- finalangel/staff 4167 2020-08-26 11:22 django-sekizai-2.0.0/PKG-INFO
-rw-r--r-- finalangel/staff 2518 2020-08-26 10:43 django-sekizai-2.0.0/README.rst
drwxr-xr-x finalangel/staff    0 2020-08-26 11:22 django-sekizai-2.0.0/django_sekizai.egg-info/
-rw-r--r-- finalangel/staff 4167 2020-08-26 11:22 django-sekizai-2.0.0/django_sekizai.egg-info/PKG-INFO
-rw-r--r-- finalangel/staff  516 2020-08-26 11:22 django-sekizai-2.0.0/django_sekizai.egg-info/SOURCES.txt
-rw-r--r-- finalangel/staff    1 2020-08-26 11:22 django-sekizai-2.0.0/django_sekizai.egg-info/dependency_links.txt
-rw-r--r-- finalangel/staff    1 2020-08-10 11:21 django-sekizai-2.0.0/django_sekizai.egg-info/not-zip-safe
-rw-r--r-- finalangel/staff   34 2020-08-26 11:22 django-sekizai-2.0.0/django_sekizai.egg-info/requires.txt
-rw-r--r-- finalangel/staff   14 2020-08-26 11:22 django-sekizai-2.0.0/django_sekizai.egg-info/top_level.txt
drwxr-xr-x finalangel/staff    0 2020-08-26 11:22 django-sekizai-2.0.0/sekizai/
-rw-r--r-- finalangel/staff   22 2020-08-26 11:21 django-sekizai-2.0.0/sekizai/__init__.py
-rw-r--r-- finalangel/staff  356 2020-08-26 10:43 django-sekizai-2.0.0/sekizai/context.py
-rw-r--r-- finalangel/staff  326 2020-08-26 10:43 django-sekizai-2.0.0/sekizai/context_processors.py
-rw-r--r-- finalangel/staff  616 2020-08-26 10:43 django-sekizai-2.0.0/sekizai/data.py
-rw-r--r-- finalangel/staff 5381 2020-08-26 10:43 django-sekizai-2.0.0/sekizai/helpers.py
-rw-r--r-- finalangel/staff    0 2020-08-26 10:43 django-sekizai-2.0.0/sekizai/models.py
drwxr-xr-x finalangel/staff    0 2020-08-26 11:22 django-sekizai-2.0.0/sekizai/templatetags/
-rw-r--r-- finalangel/staff    0 2020-08-26 10:43 django-sekizai-2.0.0/sekizai/templatetags/__init__.py
-rw-r--r-- finalangel/staff 4565 2020-08-26 10:43 django-sekizai-2.0.0/sekizai/templatetags/sekizai_tags.py
-rw-r--r-- finalangel/staff   38 2020-08-26 11:22 django-sekizai-2.0.0/setup.cfg
-rw-r--r-- finalangel/staff 1445 2020-08-26 10:43 django-sekizai-2.0.0/setup.py
drwxr-xr-x finalangel/staff    0 2020-08-26 11:22 django-sekizai-2.0.0/tests/
-rw-r--r-- finalangel/staff    0 2020-08-26 10:43 django-sekizai-2.0.0/tests/__init__.py
-rw-r--r-- finalangel/staff 1280 2020-08-26 10:43 django-sekizai-2.0.0/tests/settings.py
-rw-r--r-- finalangel/staff 14055 2020-08-26 10:43 django-sekizai-2.0.0/tests/test_core.py

github source tarball for 2.0.0:

drwxrwxr-x root/root         0 2020-08-26 11:20 django-sekizai-2.0.0/
-rw-rw-r-- root/root       295 2020-08-26 11:20 django-sekizai-2.0.0/.coveragerc
-rw-rw-r-- root/root       426 2020-08-26 11:20 django-sekizai-2.0.0/.editorconfig
-rw-rw-r-- root/root       175 2020-08-26 11:20 django-sekizai-2.0.0/.gitignore
-rw-rw-r-- root/root      1082 2020-08-26 11:20 django-sekizai-2.0.0/.travis.yml
-rw-rw-r-- root/root       849 2020-08-26 11:20 django-sekizai-2.0.0/CHANGELOG.rst
-rw-rw-r-- root/root      1486 2020-08-26 11:20 django-sekizai-2.0.0/LICENSE.txt
-rw-rw-r-- root/root        68 2020-08-26 11:20 django-sekizai-2.0.0/MANIFEST.in
-rw-rw-r-- root/root      2518 2020-08-26 11:20 django-sekizai-2.0.0/README.rst
drwxrwxr-x root/root         0 2020-08-26 11:20 django-sekizai-2.0.0/docs/
-rw-rw-r-- root/root      3142 2020-08-26 11:20 django-sekizai-2.0.0/docs/Makefile
-rw-rw-r-- root/root      6311 2020-08-26 11:20 django-sekizai-2.0.0/docs/conf.py
-rw-rw-r-- root/root     13000 2020-08-26 11:20 django-sekizai-2.0.0/docs/index.rst
drwxrwxr-x root/root         0 2020-08-26 11:20 django-sekizai-2.0.0/sekizai/
-rw-rw-r-- root/root        22 2020-08-26 11:20 django-sekizai-2.0.0/sekizai/__init__.py
-rw-rw-r-- root/root       356 2020-08-26 11:20 django-sekizai-2.0.0/sekizai/context.py
-rw-rw-r-- root/root       326 2020-08-26 11:20 django-sekizai-2.0.0/sekizai/context_processors.py
-rw-rw-r-- root/root       192 2020-08-26 11:20 django-sekizai-2.0.0/sekizai/context_processors.pyi
-rw-rw-r-- root/root       616 2020-08-26 11:20 django-sekizai-2.0.0/sekizai/data.py
-rw-rw-r-- root/root      5381 2020-08-26 11:20 django-sekizai-2.0.0/sekizai/helpers.py
-rw-rw-r-- root/root       818 2020-08-26 11:20 django-sekizai-2.0.0/sekizai/helpers.pyi
-rw-rw-r-- root/root         0 2020-08-26 11:20 django-sekizai-2.0.0/sekizai/models.py
drwxrwxr-x root/root         0 2020-08-26 11:20 django-sekizai-2.0.0/sekizai/templatetags/
-rw-rw-r-- root/root         0 2020-08-26 11:20 django-sekizai-2.0.0/sekizai/templatetags/__init__.py
-rw-rw-r-- root/root      4565 2020-08-26 11:20 django-sekizai-2.0.0/sekizai/templatetags/sekizai_tags.py
-rw-rw-r-- root/root       179 2020-08-26 11:20 django-sekizai-2.0.0/sekizai/templatetags/sekizai_tags.pyi
-rw-rw-r-- root/root      1445 2020-08-26 11:20 django-sekizai-2.0.0/setup.py
drwxrwxr-x root/root         0 2020-08-26 11:20 django-sekizai-2.0.0/tests/
-rw-rw-r-- root/root         0 2020-08-26 11:20 django-sekizai-2.0.0/tests/__init__.py
-rw-rw-r-- root/root        41 2020-08-26 11:20 django-sekizai-2.0.0/tests/requirements.txt
-rw-rw-r-- root/root      1280 2020-08-26 11:20 django-sekizai-2.0.0/tests/settings.py
drwxrwxr-x root/root         0 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/
-rw-rw-r-- root/root       228 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/basic.html
-rw-rw-r-- root/root       161 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/css.html
-rw-rw-r-- root/root       260 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/css2.html
-rw-rw-r-- root/root        88 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/easy_base.html
-rw-rw-r-- root/root        79 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/easy_inherit.html
-rw-rw-r-- root/root        90 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/eat.html
drwxrwxr-x root/root         0 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/errors/
-rw-rw-r-- root/root        70 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/errors/failadd.html
-rw-rw-r-- root/root       137 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/errors/failbase.html
-rw-rw-r-- root/root       137 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/errors/failbase2.html
-rw-rw-r-- root/root        74 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/errors/failinc.html
-rw-rw-r-- root/root        43 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/errors/failrender.html
drwxrwxr-x root/root         0 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/inherit/
-rw-rw-r-- root/root       336 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/inherit/base.html
-rw-rw-r-- root/root        90 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/inherit/baseinc.html
-rw-rw-r-- root/root       105 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/inherit/chain.html
-rw-rw-r-- root/root       193 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/inherit/extend.html
-rw-rw-r-- root/root        32 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/inherit/extinc.html
-rw-rw-r-- root/root         0 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/inherit/nullbase.html
-rw-rw-r-- root/root        87 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/inherit/nullext.html
-rw-rw-r-- root/root        39 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/inherit/spacechain.html
-rw-rw-r-- root/root        37 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/inherit/subvarchain.html
-rw-rw-r-- root/root       248 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/inherit/super_blocks.html
-rw-rw-r-- root/root        19 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/inherit/varchain.html
-rw-rw-r-- root/root       122 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/named_end.html
-rw-rw-r-- root/root       248 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/namespaces.html
drwxrwxr-x root/root         0 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/processors/
-rw-rw-r-- root/root       170 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/processors/addtoblock_namespace.html
-rw-rw-r-- root/root       165 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/processors/addtoblock_null.html
-rw-rw-r-- root/root       171 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/processors/namespace.html
-rw-rw-r-- root/root       166 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/processors/null.html
-rw-rw-r-- root/root       166 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/unique.html
-rw-rw-r-- root/root       251 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/variables.html
-rw-rw-r-- root/root       169 2020-08-26 11:20 django-sekizai-2.0.0/tests/templates/with_data.html
-rw-rw-r-- root/root     14055 2020-08-26 11:20 django-sekizai-2.0.0/tests/test_core.py
-rw-rw-r-- root/root      1067 2020-08-26 11:20 django-sekizai-2.0.0/tox.ini