PR process: Amend developer documentation (i.e PR titles must start with one of the categories)
NicolaiRidani opened this issue · comments
Changes to the PR process
- No need to update CHANGELOG.rst anymore
- information for CHANGELOG.rst release will be directly pulled by the releases script
- Now using conventionalcommits.org guidelines
- scopes already implemented here: https://github.com/django-cms/django-cms/blob/develop/scripts/make-changelog#L10-L16
Hi @goutnet this task was assigned to me by the Tech Committee. I am not sure where exactly to add the information about the new PR naming requirements.
Would you agree that the best place to inform users on how to name their PR according to our guidelines would be the PR template ->https://github.com/django-cms/django-cms/blob/develop/.github/PULL_REQUEST_TEMPLATE.md ?
Or is this a whole new topic for our documentation? Because afaik we do not have a section about how to create a PR in the documentation.
thx
Actually, I think we already did that in the 3.9.x template (maybe already
in develop) ?
--
Florian Delizy
…On Thu, Jun 10, 2021 at 5:49 PM Nicolai ***@***.***> wrote:
Hi @goutnet <https://github.com/goutnet> this task was assigned to me by
the Tech Committee. I am not sure where exactly to add the information
about PR nomenclature.
Would you agree that the best place to inform users on how to name their
PR according to our guidelines would be PR template ->
https://github.com/django-cms/django-cms/blob/develop/.github/PULL_REQUEST_TEMPLATE.md
?
Or is this a whole new topic for our documentation? Because afaik we do
not have a section about how to create a PR in the documentation.
thx
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#68 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA3BAG7HJPQU3FGR2W4JKADTSCDDBANCNFSM45JMBOKA>
.