Django 3 issues - six is no longer availiable in django.utils

Question

Django 3 issues - six is no longer availiable in django.utils

maddrum opened this issue 5 years ago · comments

Hello!
"SIX" is not available in django.utils in Django 3, since all python 2 support is dropped.
So importing "SIX" in core.py throws exception.

Angelo Dini commented 5 years ago

👍

Aidas Bendoraitis · Answer 1 · Sat Dec 28 2019 17:03:42 GMT+0800 (China Standard Time)

Hello! What is the current roadmap for the upgrade? We need this for the django-sekizai to function on Django 3.0. Does the proposed pull request lack something? How can we help to push it forward?

Iacopo Spalletti · Answer 2 · Sat Dec 28 2019 22:31:46 GMT+0800 (China Standard Time)

Ping @FinalAngel : as soon as #50 is merged, we can make a release

michael93pl · Answer 3 · Wed Jan 08 2020 01:47:30 GMT+0800 (China Standard Time)

Hello! How the situation looks like regarding the upcoming merge? Django-cookie-law uses django-classy-tags and the issue seems to be connected only with the six version. Is there something I can help with to speed the merge? Cheers!

pallavg · Answer 4 · Thu Jan 09 2020 05:47:41 GMT+0800 (China Standard Time)

I am also experiencing issues witht his. Django-wiki has an dependency on django-classy-tags (via django-sekizai), and I just hacked the source code to change import django.util.six -> import six to get it work. It will be great if #50 can be merged as and a release is made. Thank you.

Angelo Dini · Answer 5 · Thu Jan 09 2020 15:08:21 GMT+0800 (China Standard Time)

thanks for the feedback, I'm prepping to get Django 3 support across the supported addons and the CMS itself.

Aidas Bendoraitis · Answer 6 · Thu Jan 09 2020 18:03:48 GMT+0800 (China Standard Time)

@FinalAngel Would it be possible to release a new version of django-classy-tags somewhen in the upcoming week, before doing the final updates of Django CMS?

Angelo Dini · Answer 7 · Fri Jan 10 2020 16:13:26 GMT+0800 (China Standard Time)

@archatas we potentially can merge the PR. Alternatively you can install classy-tags from Github temporarily. All depends a bit on testing and how fast I progress.

Iacopo Spalletti · Answer 8 · Fri Jan 10 2020 17:09:31 GMT+0800 (China Standard Time)

@FinalAngel I think it's worth to release classy-tags and sekizai very early in the django 3 migration process as they are enabler for a lot of third party apps that will allow them to catch up quicker with the django CMS releases
I can do this myself, if needed

maddrum · Answer 9 · Mon Jan 13 2020 14:48:50 GMT+0800 (China Standard Time)

Is this project abandoned? It has been a month and no release has been made.

Angelo Dini · Answer 10 · Mon Jan 13 2020 15:07:00 GMT+0800 (China Standard Time)

@yakky yeah probably this week :)

Iacopo Spalletti · Answer 11 · Mon Jan 13 2020 15:09:44 GMT+0800 (China Standard Time)

👍 let me know if you want me to handle it

…

On 13 January 2020 08:07:01 CET, Angelo Dini ***@***.***> wrote: @yakky yeah probably this week :) -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #48 (comment)

Angelo Dini · Answer 12 · Mon Jan 13 2020 16:29:56 GMT+0800 (China Standard Time)

@yakky you are very welcome to merge and release as well!

Iacopo Spalletti · Answer 13 · Mon Jan 13 2020 17:58:25 GMT+0800 (China Standard Time)

@yakky you are very welcome to merge and release as well!

I can merge but can't release (not added on PyPi)

Aidas Bendoraitis · Answer 14 · Mon Jan 13 2020 18:40:55 GMT+0800 (China Standard Time)

@yakky Can you please at least merge the branches? It would be possible to use the installation directly from GitHub temporarily.

Iacopo Spalletti · Answer 15 · Mon Jan 13 2020 20:02:21 GMT+0800 (China Standard Time)

@FinalAngel I'd go with #50 (using six explicitly instead of #51 which uses a compat method) as it's more in line with what would be done in the other django cms apps

Iacopo Spalletti · Answer 16 · Mon Jan 13 2020 20:19:39 GMT+0800 (China Standard Time)

@FinalAngel I need an explicit review, otherwise I can't merge it due to repo settings :)