divio / aldryn-django

An opinionated Django setup for Divio Cloud

Home Page:https://www.divio.com

Repository from Github https://github.comdivio/aldryn-djangoRepository from Github https://github.comdivio/aldryn-django

MEDIA_URL not set correctly

petrklus opened this issue · comments

After upgrading to Aldryn Django 4.2.9, we are seeing issues with MEDIA_URL not being set.

Looking at the code, this seems to be a regression as the function is working correctly on Aldryn Django 3.2.23.

Relevant portion of the code for the 3.2 version:

https://github.com/divio/aldryn-django/blob/3.2.23.0/aldryn_config.py#L398

The above has been fixed in version 3.2.14.0, via commit c11004a.

It seems that the 4.2.9 version is using the old&broken MEDIA_URL logic: https://github.com/divio/aldryn-django/blob/4.2.9/aldryn_config.py#L407

I believe the same logic as it's in use since 3.2.14 should work for the 4.2 branch.

@petrklus I think this has been fixed with #318