divideconcept / FluidLite

Very light version of FluidSynth designed to be hardware, platform and external dependency independent.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Missing default minimum note duration (10 ms)

mmontag opened this issue · comments

Should be an easy fix to restore this missing piece.
I believe all it requires is this line in fluid_synth.c:

void fluid_synth_settings(fluid_settings_t* settings)
{
  ...
  fluid_settings_register_int(settings, "synth.min-note-length", 10, 0, 65535, 0, NULL, NULL);
}

I am attaching a test file with some zero-duration Synth Tom notes on Channel 11.
GAME18.MID.zip

It's probably deeper than that, because that line seems to be already here :

fluid_settings_register_int(settings, "synth.min-note-length", 10, 0, 65535, 0, NULL, NULL);

Hmm, okay. Well this is the patch that seemed to fix it for me:

mmontag/chip-player-js@c0e4db7

It seems you were not using the latest version of FluidLite; all theses lines were commited in FluidLite 2 years ago :-)
9e50e83

Ok, thanks! But yikes, where did I go wrong...