ditdot-dev / vue-flow-form

Create conversational conditional-logic forms with Vue.js.

Home Page:https://www.ditdot.hr/en/vue-flow-form

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Mutating prop issue

henrikruscon opened this issue · comments

This line of code mutates prop

this.question.answered = this.isValid()

Hi @henrikdahl,

thanks for the report. Can you provide a test case when this error happens? Or are you referring to the fact we are changing a property of QuestionModel (or a "prop" of the question component if you're defining questions with components; although take note we're actually using a copy of the prop value in this case)? This is inevitable and necessary with how Vue Flow Form is currently designed - it also changes many other properties of QuestionModel, but this is unavoidable (and completely expected) when using class instances.

Closing - Inactive issue