Giters

disorderedmaterials / dissolve

Structure refinement software for total scattering data

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Superfluous information in GeometryListKeyword Serialisation

rprospero opened this issue · comments

commented

Currently, the GeometryListKeyword serialises the GeometryType and requires that information to be present in the deserialisation. However, during the development of PR #1619, we noticed that the actual type is defined by the context in the program. As a result, there is only one relevant type at any possible location. This makes the type information redundant. Even if we were concerned about a type mismatch, having the correct type label there does nothing to ensure that the correct parameters for that type are present.

Removing the type parameter with the GeometryListKeyword serialisation and deserialisation will simplify the code and make input files easier to create without having any adverse effect on the program.