Lots of code in different stores can be consolidated

Question

discentem opened this issue a year ago · comments

and

are identical. Instead maintaining this code in each of the store providers (and future providers), we should abstract this out.

BK · Answer 1 · Sun May 28 2023 12:08:54 GMT+0800 (China Standard Time)

@natewalck do you feel that this issue is resolved by #111?

Nate Walck · Answer 2 · Sun May 28 2023 20:41:24 GMT+0800 (China Standard Time)

Not entirely.

#111 still does config checking within the store. (Specifically, checking for the metadata extension config to exist)

If a config is required for cavorite to run, we should be checking it and bailing (or set a default) in the code that is reading the config. This should live here: https://github.com/discentem/cavorite/blob/main/internal/cli/init.go#L72

The config code should own the config validation, if that makes sense.

BK · Answer 3 · Wed May 31 2023 08:09:47 GMT+0800 (China Standard Time)

Closing this. Opened #113 to keep track of the config validation changes @natewalck is requesting