dingo / api

A RESTful API package for the Laravel and Lumen frameworks.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Compability with PHP 8

AnNajib opened this issue · comments

dingo/api[v3.0.0-rc1, ..., v3.0.5] require php ^7.2.5 -> your php version (8.0.0) does not satisfy that requirement.

@specialtactics The pull request for this is still open, can you look at it?

Please fix.

Waiting for a fix to this

When can we expect a fix to this?
I tried dingo 3.0.5 version as well, but every time I am getting the same error :/

Argument 1 passed to Dingo\Api\Http\Response::setFormatters() must be of the type array, null given, called in .......vendor/dingo/api/src/Provider/DingoServiceProvider.php on line 34

PHP 8.1 will be releasing this year, and PHP 8 been released for some time, so would love to see support for PHP8.0.

Please any update here we need to use php8

commented

Hey everyone

After merging some PRs and doing further work and investigation, master seems to work for me with php 8.

I would love it if some people could set their composer to dev-master and help me test this out if you are using php 8, run any unit tests you have and do any other testing you can, and give me feedback on whether you find any issues.

@specialtactics since no one bothered to reply yet: dev-master works fine for me with PHP-8 - thanks 👍

php version: 8.0.5

composer require dingo/api:dev-master

works fine for me

commented

Ok guys, thanks for the feedback, I'll tag it.

@specialtactics Thank you for tagging this.

Is there any concerns about adding a v0.4.3 for dingo/blueprint?
I see you added "php": "^7.2.5|^8.0" to a v0.4.3-rc1.

I'm hoping for v0.4.3 to make thing nice for composer.

commented

@tfettig I think that's fine as long as people have tested it, but if you add it to composer as "~0.4" it will pick it up and work, so long as you dont have minimum stability requiremetns too high.

@specialtactics I've been run development tests using the rc tags for a while now and haven't had any problems.
I see you merged it in with the v0.4.3 tag. Thank you.