digitalevidencetoolkit / deptoolkit

The Toolkit API, app, and browser extension. Start preserving now.

Home Page:https://digitalevidencetoolkit.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Fetching an item's history in the UI triggers a full-page redraw

basilesimon opened this issue · comments

I believe this is a relatively recent regression, but am unable to pin down where from.

The process of displaying an item's history is relatively convoluted and requires the clicking of a button.

This action triggers Ledger.addHistoryTo(entry), which updates the $ledgerData (which is a store).

I would have expected this update to not trigger a full-page redraw, but it does.

I've located the regression: it's "WIP: Verify an archive" pull request.

This PR introduces a fade:in Svelte transition to the <LedgerEntries />.

I was under the impression that Stores would behave a little differently, but this Issue put me on the right track: it's not the async nature of my stores that is the issue here, and we do expect a whole-store comparison when it's updated.

The faded transition only makes it more obvious. It was added as a cosmetic change: when looking at the /verify route, we drag and drop pictures that are reverse-looked up in the database, and positive matches appear in the UI as the requests come back. A little fade made it look quite nice, and that was that.

I'll have a think about what to do here.

@bayre – this is the issue I mentioned to you yesterday. Looks like I'm sorted!