digidem / react-dimensions

[Looking for maintainers]

Home Page:http://lab.digital-democracy.org/react-dimensions/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

react-dimensions gives errors about peer dependencies when trying to upgrade to react 15

kaiyoma opened this issue · comments

The new version of React was released today (https://facebook.github.io/react/blog/2016/04/07/react-v15.html), but when I update my package.json to set react and react-dom to 15.0.0, I get this error during updating:

$ npm install
- base62@0.1.1 node_modules\base62
- esprima-fb@13001.1001.0-dev-harmony-fb node_modules\esprima-fb
- jstransform@10.1.0 node_modules\jstransform
- envify@3.4.0 node_modules\envify
arista-geiger@0.0.1 C:\Users\Kyle Getz\Work\event-viewer
+-- UNMET PEER DEPENDENCY react@15.0.0
| `-- fbjs@0.8.0
|   `-- isomorphic-fetch@2.2.1
|     +-- node-fetch@1.5.0
|     | +-- encoding@0.1.12
|     | | `-- iconv-lite@0.4.13
|     | `-- is-stream@1.0.1
|     `-- whatwg-fetch@0.11.0
`-- UNMET PEER DEPENDENCY react-dom@15.0.0

npm WARN optional Skipping failed optional dependency /chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture: fsevents@1.0.11
npm WARN react-dimensions@1.0.2 requires a peer of react@^0.14.0 but none was installed.
npm WARN react-dimensions@1.0.2 requires a peer of react-dom@^0.14.0 but none was installed.
npm ERR! code 1

Is this an issue with react-dimensions?

+1 should be as simple as updating package.json with || ^15.0.0

Fixed with #20

Awesome! When can we expect a release?

Just released v1.1.0 with other fixes / additions too

Great, thanks!

Awesome!