Giters

diegojromerolopez / gelidum

Freeze your objects in python

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Non-free bits in release

dschwoerer opened this issue · comments

commented

I am currently trying to package gelidum for fedora, however I noticed that the package is non-free, as it contains a CC BY-NC 2.0 image.

This is listed in fedora license list as a non-acceptable license.
While I could remove the image always from the release, not being forced to do this would be greatly appreciated.

The NC part might also violate the PYPI terms of use but I am not a lawyer ...

commented

Dear @dschwoerer

Thank you for bringing this issue to my attention.

I have just replaced the image for another one that is public domain (CC0). The change has already been pushed to main and to the 0.5.5 version in pypi, so you could work with that version.

Thank you again for your packaging efforts!

Kind regards!

commented

Thanks, much appreciated 👍

I noticed one minor issue, version.txt and requirements.txt are installed to $PREFIX. I currently just delete them, but it would be cleaner if they wouldn't be installed in the first place.

commented

Removing version.txt and requirements.txt from data_files did that (why did I put it there in the first place? I wonder).

Version 0.5.6 (already in pypi) is updated with that change. Please, confirm if that works for you.

Thanks for reporting!

commented

Unfortunately removing version.txt and requirements.txt breaks the conda-forge setup - that apparently needs to run setup.py again and errors because it can't find the files.

I think the easiest fix for this would be to:

  • remove version.txt and just put the version number directly in setup.py (as long as it's not needed anywhere else?)
    • there's also setuptools_scm which can automatically create the version number from the git tags, but that's probably overkill here.
  • put the dependencies (if/when there are any) in setup.py and change requirements.txt to be just: 
    .
    which, if requirements.txt is ever used, effectively tells pip to get the requirements from setup.py (for more on why both requirements.txt and setup.py exist, and might be different, see e.g. https://caremad.io/posts/2013/07/setup-vs-requirement/).
commented

@johnomotani could you please check this PR #27?

commented

@johnomotani merged and updated to 0.5.7 in pypi. Thank you!