Suppress obsolete warnings in generated code

[Frederic Morel]

Issue
When I mark a property as obsolete but don't use [IgnoreEquality], then I get build warnings about usages of the obsolete property.

I would expect those to be suppressed because they will go away when the property is removed anyway. In the meantime, I can't use [Obsolete] on properties in projects where I treat warnings as errors.

Solution 1
Use a pragma to suppress build warnings when comparing obsolete things in the generated source.

Solution 2
Add a toggle on [Equatable] to decide whether to use a pragma to suppress obsolete warnings. Something like:

[Equatable(SuppressObsoleteWarnings = true)]
public partial record Something
{
  public string Thing1 { get; set; }
  [Obsolete]
  public string Thing2 { get; set; }
}

If you have a preferred way of doing it, I'd be more than happy to write up a PR.

[Diego Frata]

I think Solution #1 is more desirable, and I'd be happy for you to send a PR! ---- On Wed, 11 May 2022 19:18:02 +0100 ***@***.*** wrote ---- Issue When I mark a property as obsolete but don't use [IgnoreEquality], then I get build warnings about usages of the obsolete property. I would expect those to be suppressed because they will go away when the property is removed anyway. In the meantime, I can't use [Obsolete] on properties in projects where I treat warnings as errors. Solution 1 Use a pragma to suppress build warnings when comparing obsolete things in the generated source. Solution 2 Add a toggle on [Equatable] to decide whether to use a pragma to suppress obsolete warnings. Something like: [Equatable(SuppressObsoleteWarnings = true)] public partial record Something { public string Thing1 { get; set; } [Obsolete] public string Thing2 { get; set; } } If you have a preferred way of doing it, I'd be more than happy to write up a PR. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[Frederic Morel]

#20 is up!