dhilt / vscroll

A JavaScript Virtual Scroll Engine

Home Page:https://dhilt.github.io/vscroll/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Reactive props should persist if the Workflow is re-created with the the same Datasource

dhilt opened this issue · comments

Since the Workflow entity depends on the Datasource instance, there may be a situation when the same Datasource is being passed to a new Workflow instance after the previous one is disposed.

Adapter re-initialization

The Datasource is instantiated once, and its Adapter is also instantiated once. But the Adapter is initialized in the end of the Workflow instantiation. So if we have multiple Workflows instantiated one by one with the same Datasource (having the same instantiated Adapter), the Adapter falls into multiple initialization.

Currently re-initialization of the existed Adapter loses Reactive props config. This needs to be fixed. Reactive props should persist through re-initialization of the Adapter.

Source of the issue: dhilt/ngx-ui-scroll#270.