Distinguishing text/binary messages

Question

Distinguishing text/binary messages

jpek42 opened this issue 8 years ago · comments

Hi -

Thanks for the work on this library. It's certainly the easiest-to-consume C++ WS library I've come across.

One thing that I don't see is a way to determine whether an incoming message is binary or text. The _dispatchBinary method gets the opcode, but then just eats it without telling the callable. It seems like it would make sense to pass the type on as well.

Or maybe I'm missing something in the way things are supposed to work.

David Baird · Answer 1 · Sat Jun 11 2016 23:01:30 GMT+0800 (China Standard Time)

Hi @jpek42, sorry for taking awhile to get back to this issue. This is a limitation of the API: The information about text or binary can be inspected based on which callback was called. I.e., two callbacks need to be registered, one for text and one for binary.

Jeff Pek · Answer 2 · Sun Jun 12 2016 03:04:50 GMT+0800 (China Standard Time)

Thanks for the response. I guess it wasn't clear what those 2 methods were (dispatch, dispatchBinary). Are they just establishing callbacks? So there's no need to call them within the loop?

David Baird · Answer 3 · Thu Jun 23 2016 13:47:00 GMT+0800 (China Standard Time)

Hi @jpek42, the original issue you raise is accurate: this is a limitation of the API, and also unexpected/confusing.

The easiest solution would be: make sure that your service ever only sends one or the other (text or binary), and never mixes them.

The more better solution would be to fix the API. I will see if I can do that this weekend, or pull requests are also welcome. Thanks for reporting this issue.