Add support for Linux and Windows?
e-alfred opened this issue · comments
Hello,
this app looks quite nice, can you make a port for Linux and Windows? As it is written in Electron this might be doable with relatively low effort? Are there some pieces that are MacOS-specific?
As it is this app contains nothing that is Mac specific, so it should be straight forward to add support for Linux and Windows, however I currently have no means of testing on those platforms.
The code is here on github and anyone is welcome to fork it and make the necessary modifications.
I built your app for Windows and Linux by changing this line: cabbaab
I use it for months now and it works pretty well.
I released builds for Linux and Windows (64 bit) on my fork:
https://github.com/e-alfred/nextcloud-bookmark-manager/releases/tag/2.0.2
The only incompatibility I found is the context menu for selecting a browser which relies on Applescript:
@e-alfred That's fantastic, thanks!
Yes, the browser menu uses AppleScript to open the selected browser - that would need to be commented out for Win / Linux.
Other things to check perhaps would be that all the menu commands are valid also for Win / Linux, and also preload.js
In preload.js there is a check to see what version of MacOS is being used. Based on the version the app decides wether to use accent colors or the default mac blue for selections. Probably under Win / Linux it's defaulting to blue -- but it may need to be checked.
@e-alfred with regards to the use of applescript for opening selected browsers -- the next release (v2.0.3) will no longer be using applescript. I'm now using detect-browsers to directly find and open installed browsers. This should work on Linux / Win.