dflydev / dflydev-stack-basic-authentication

HTTP Basic Authentication Stack middleware

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Pimple is a requirement. Why?

adammbalogh opened this issue · comments

It should not depend on Pimple.

(or you should add the requirement to the composer.json at least)

I missed this because I require-dev Silex which gets Pimple. The fact that I didn't require Pimple but it works for me and for testing was just a sad coincidence. :(

If you want to add it as a dependency to composer.json I'll merge it. Otherwise, I'll keep this open to try and remember to do it myself later.

Long-term goal would be to eventually replace Pimple w/ some of these as we are using it, but requiring all of Pimple itself for what we are using it for is probably overkill.

Yeah you're right. Anyway pimple is so small, it does not hurt anyone.

commented

It should not depend on Pimple.

+1 for not requiring pimple