dfinity / sdk

IC SDK: a Software Development Kit for creating and managing canister smart contracts on the ICP blockchain.

Home Page:https://internetcomputer.org/developers

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

`--mode reinstall` breaks regenerating lsp dids

letmejustputthishere opened this issue · comments

when deploying the ledger locally using the ledger.private.did and after that swapping to ledger.public.did (no service arguments) and deploying a canister that has a dependency on the ledger, if i use
dfx deploy my_canister_that_depends_on_the_ledger --mode reinstall -y, the did file in .dfx/local/lsp/<ledger_canister_id>.did is not being updated to reflect the fact that no init args are needed. this leads to the motoko extension to complain.
if i use dfx deploy my_canister_that_depends_on_the_ledger instead, everything works as expected

I expected to see this happen:
the dids in the lsp folder are generated correctly, even if i use --mode reinstall

Instead, this happened:
the dids in the lsp folder still contain the service arguments, and therefore the motoko language extension complains.

Meta

dfx --version:

dfx 0.13.1

Screenshot 2023-03-02 at 16 00 12

tagging @rvanasa as this might also interesting for him

Root cause is the same as #2969 - treating this as a duplicate, even though the symptoms are not the same