Giters

dfinity / agent-js

A collection of libraries and tools for building software around the Internet Computer, in JavaScript.

Home Page:https://agent-js.icp.xyz

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Evaluate AssetManager Performance

krpeacock opened this issue · comments

commented

Describe the Issue
We reduced the upload size in #603 in order to get the tests to pass. Because large uploads will be a common use case for this tool, we should evaluate and benchmark various sizes of uploads in e2e tests in a browser and nodejs context

Instead of random bytes, we can also use some pre-existing assets with various file sizes - maybe a single image exported at different resolutions would be straightforward

Acceptance Criteria
Nodejs

  • 2mb(small upload)
  • 3mb(chunked upload)
  • 10mb(moderate upload)
    Browser
  • 2mb(small upload)
  • 3mb(chunked upload)
  • 10mb(moderate upload)
commented

Larger asset tests were timing out due to #638. PR to increase asset sizes back to 1MB and 3MB: #639

I'll make another PR afterwards to add 10MB tests and browser tests. I would make a 1MB test instead of 2MB test so it doesn't get chunked (3MB and 10MB will).