Giters

dferber90 / jsdom-screenshot

📸 Take screenshots of jsdom with puppeteer

Home Page:https://github.com/dferber90/visual-regression-testing-example

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Change puppeteer to peer dependency?

peterjosling opened this issue · comments

commented

This package specifies puppeteer ^1.12.2 as a dependency, which is a version that is pinned to Chrome 73. As this is a dependency of the package, there's no way to specify a different Chrome version.

Changing puppeteer to be a peer dependency would allow users of the package to specify their own version of puppeteer and be in control of the version of Chrome that gets used.

commented

Thanks for the hint @peterjosling!

iirc, the puppeteer api had a breaking change. If we make it a peer dep, we should update our puppeteer usage to ensure we can support the latest version (and update the readme/install instructions)