Change the default password length to 16 characters
devshawn opened this issue · comments
Increasing to length 16 increases "time to crack" by more than a factor of 300,000,000 (based on baselines from https://github.com/howsecureismypassword/hsimp).
So, let's change the default length to 16 within the server.
can i take this up??
@Apoorva-13 - Yes you can!
@devshawn pls guide me where am i going wrong.
@devshawn where and what all changes are needed , i am new to this ,would need some guidance pls.
@Apoorva-13 I think the build is failing because there is also a test associated with the default password length that needs updating... check out this file https://github.com/devshawn/password.live/blob/master/source/server/__tests__/services/password.service.spec.js#L9
Sorry @Apoorva-13, I did not see you took over this issue. My PR passed the check. You can look at it as an example.
Its fine but i had formally taken up this issue, You should alteast look up on what is happening in the comment section and if u were working on this u could have commented so that others don't work. This is the basic rule which i follow before taking up an issue and even many others follow.
@Apoorva-13: You're right. I formally apologize. You probably commented after I started working on it. Anyways, I'll close my PR.
Thanks @Apoorva-13 & @ulziibuyan for giving it a shot! :)