devpunks / snuggsi

snuggsi ツ - Easy Custom Elements in ~1kB

Home Page:https://snuggsi.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

What is the reason for the limited npm/node engines?

JoshuaBehrens opened this issue · comments

Expected Behavior

I can just do npm i snuggsi

Current Behavior

It tries to install on npm i snuggsi but fails with

Unsupported engine for snuggsi@0.13.198: wanted: {"npm":"5.0.x","node":"9.8.x"} (current: {"node":"14.4.0","npm":"6.14.4"})

Possible Solution

Do not define any engines in such a limiting manner.

Steps to Reprod(uce)

  1. Have the latest node/npm
  2. npm i snuggsi

Context

I want to try to integrate snuggsi into my one of my webpack based projects as it sounds pretty neat. I stumbled upon this limitation. What is the reason for these engine entries? I was looking into the git history but was not very successful getting the reason.

Your Environment

  • Version used: 0.13.198
  • Environment name and version: node 14.4, npm 6.14.4
  • Operating System and version: Ubuntu 20.04

I think it just hasn't been updated in a long while. A PR would be appreciated.

So a possible solution is to remove the constraints completely or are these needed?

I think the minimum may be a hard requirement, but I think an upper constraint is just a question of testing