devitocodes / opesci-fd

A framework for automatically generating finite difference models from a high-level description of the model equations.

Home Page:http://opesci.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

set_accuracy() refactoring

ggorman opened this issue · comments

  1. set_accuracy() needs to be replaced with set_order(). Make sure that the parameters really do mean order. --- Follow the "Principle of least astonishment"
  2. Currently the code fails with an unhelpful message when set_accuracy (to be renamed set_order()). Set a sensible default instead (e.g. 2nd order) and perhaps add some checks to make sure that something sensible is being asked for.

sorted now.

Is this fixed now that PR #47 has landed?