devitocodes / devito

DSL and compiler framework for automated finite-differences and stencil computation

Home Page:http://www.devitoproject.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Some tests fail

GaetanLepage opened this issue · comments

Hello,

When running the tests I face the following failures:

=========================== short test summary info ============================
FAILED examples/seismic/self_adjoint/test_utils.py::TestUtils::test_setupWOverQ[float32-11-100.0-0.1-0.06283185307179587-10-shape1] - AttributeError: 'numpy.float64' object has no attribute 'is_Rational'
FAILED examples/seismic/self_adjoint/test_utils.py::TestUtils::test_setupWOverQ[float32-11-100.0-1.0-0.06283185307179587-10-shape0] - AttributeError: 'numpy.float64' object has no attribute 'is_Rational'
FAILED examples/seismic/self_adjoint/test_utils.py::TestUtils::test_setupWOverQ[float32-11-100.0-1.0-0.06283185307179587-10-shape1] - AttributeError: 'numpy.float64' object has no attribute 'is_Rational'
FAILED tests/test_derivatives.py::TestTwoStageEvaluation::test_index_derivative - AttributeError: <class 'devito.finite_differences.differentiable.IndexDeriv...
FAILED examples/seismic/self_adjoint/test_utils.py::TestUtils::test_setupWOverQ[float32-None-10.0-0.1-0.06283185307179587-10-shape0] - AttributeError: 'numpy.float64' object has no attribute 'is_Rational'
FAILED examples/seismic/self_adjoint/test_utils.py::TestUtils::test_setupWOverQ[float32-None-10.0-0.1-0.06283185307179587-10-shape1] - AttributeError: 'numpy.float64' object has no attribute 'is_Rational'
FAILED examples/seismic/self_adjoint/test_utils.py::TestUtils::test_setupWOverQ[float32-None-10.0-1.0-0.06283185307179587-10-shape0] - AttributeError: 'numpy.float64' object has no attribute 'is_Rational'
FAILED examples/seismic/self_adjoint/test_utils.py::TestUtils::test_setupWOverQ[float32-None-10.0-1.0-0.06283185307179587-10-shape1] - AttributeError: 'numpy.float64' object has no attribute 'is_Rational'
FAILED examples/seismic/self_adjoint/test_utils.py::TestUtils::test_setupWOverQ[float32-None-100.0-0.1-0.06283185307179587-10-shape0] - AttributeError: 'numpy.float64' object has no attribute 'is_Rational'
FAILED examples/seismic/self_adjoint/test_utils.py::TestUtils::test_setupWOverQ[float32-None-100.0-0.1-0.06283185307179587-10-shape1] - AttributeError: 'numpy.float64' object has no attribute 'is_Rational'
FAILED examples/seismic/self_adjoint/test_utils.py::TestUtils::test_setupWOverQ[float32-None-100.0-1.0-0.06283185307179587-10-shape0] - AttributeError: 'numpy.float64' object has no attribute 'is_Rational'
FAILED examples/seismic/self_adjoint/test_utils.py::TestUtils::test_setupWOverQ[float32-None-100.0-1.0-0.06283185307179587-10-shape1] - AttributeError: 'numpy.float64' object has no attribute 'is_Rational'
FAILED examples/seismic/self_adjoint/test_utils.py::TestUtils::test_setupWOverQ[float32-11-10.0-0.1-0.06283185307179587-10-shape0] - AttributeError: 'numpy.float64' object has no attribute 'is_Rational'
FAILED examples/seismic/self_adjoint/test_utils.py::TestUtils::test_setupWOverQ[float32-11-10.0-0.1-0.06283185307179587-10-shape1] - AttributeError: 'numpy.float64' object has no attribute 'is_Rational'
FAILED examples/seismic/self_adjoint/test_utils.py::TestUtils::test_setupWOverQ[float32-11-10.0-1.0-0.06283185307179587-10-shape0] - AttributeError: 'numpy.float64' object has no attribute 'is_Rational'
FAILED examples/seismic/self_adjoint/test_utils.py::TestUtils::test_setupWOverQ[float32-11-10.0-1.0-0.06283185307179587-10-shape1] - AttributeError: 'numpy.float64' object has no attribute 'is_Rational'
FAILED examples/seismic/self_adjoint/test_utils.py::TestUtils::test_setupWOverQ[float32-11-100.0-0.1-0.06283185307179587-10-shape0] - AttributeError: 'numpy.float64' object has no attribute 'is_Rational'

Is this expected or do I have setup my environment wrong ?

What version of devito, numpy and sympy do you have installed

What version of devito, numpy and sympy do you have installed

devito: 4.8.1
numpy: 1.25.1
sympy: 1.12

That's quite odd I can't seem to reproduce the error. What is the python/pytest version and how did you install devito?

Indeed I was not able to reproduce the failure in a "standard" environment.
I am facing those when packaging devito for nixpkgs. Hence, it is a non-standard setup.
I realized that we had to disable several other tests that are failing for nix-related reasons.
It is probably the case for the two aforementioned tests.

I will close this issue, sorry for the false positive.

I am facing those when packaging devito for nixpkgs.

Interesting. We are always happy to help making devito easier to use so let us know if there is anything we can do. We'll gladly add it to our installation page as well when done.

Thank you !
It is actually already packaged and can be used today.
I encountered those issues in the process of updating devito to the latest version.
Disabling some tests is a common practice for us at there can be many reasons why tests fail during our build process.

I was the one who packaged it at first. Yeah, most of the test fail either because they require MPI or because for some reason the sympy result of some tests simply fail. I am super busy rn so I can't update it myself, but the solution so far has been to disable any tests that fail.

Ok ! Thanks for the precision :)

Thanks for updating it for us!