Remove requirement for `AWS_BUCKET_URL` or `BUCKETEER_BUCKET_URL` environment variable

Question

Remove requirement for `AWS_BUCKET_URL` or `BUCKETEER_BUCKET_URL` environment variable

crcastle opened this issue 4 years ago · comments

Bucketeer does not create or populate this environment variable, and its value can be constructed using the BUCKETEER_BUCKET_NAME or AWS_BUCKET_NAME environment variable.

So config.js can probably be changed like this:

AWS_BUCKET_URL: `https://${process.env.BUCKETEER_BUCKET_NAME || process.env.AWS_BUCKET_NAME}.s3.amazonaws.com`

Vishal Sharma · Answer 1 · Tue Oct 13 2020 15:55:08 GMT+0800 (China Standard Time)

@crcastle I would Iike to work on this. Can you please assign it to me

Chris Castle · Answer 2 · Wed Oct 14 2020 07:57:23 GMT+0800 (China Standard Time)

Thank you @vishalCR7 ! Let me know if you have any questions. Please open a Pull Request when you're ready for us to review and merge your code.