Support for puppetlabs-apt >= 3.0.0

Question

Support for puppetlabs-apt >= 3.0.0

madelaney opened this issue 7 years ago · comments

I'd like to be able to use this module, however, the version restriction on puppetlabs-apt is blocking me as modules are using version 3.0.0 or newer.

Mike Delaney · Answer 1 · Sat Oct 21 2017 00:54:02 GMT+0800 (China Standard Time)

I'd be happy to do a pull-request, if you'd accept the change.

Tomas Barton · Answer 2 · Sat Oct 21 2017 06:33:38 GMT+0800 (China Standard Time)

@madelaney Hi, have a look at 1.x branch and let me know if that works for you. I assume you're using Puppet 4, right?

Mike Delaney · Answer 3 · Sat Oct 21 2017 21:06:38 GMT+0800 (China Standard Time)

@deric , That looks like it should do it; just based on metadata.json

Tomas Barton · Answer 4 · Sat Oct 21 2017 22:41:41 GMT+0800 (China Standard Time)

Tests are failing on Puppet 5, Puppet 4 should be ok. But a patch for older facter might be necessary - that's why I haven't released it yet.

Mike Delaney · Answer 5 · Sat Oct 21 2017 23:51:57 GMT+0800 (China Standard Time)

Prior to seeing your first reply, I was able to get tests working on Puppet 4.3 (which should also work in Puppet 5.x).

I'll push my changes to my fork, so you can take a look; I did introduce a new gem. Feel free to use/ignore.

Mike Delaney · Answer 6 · Sun Oct 22 2017 02:08:59 GMT+0800 (China Standard Time)

@deric , I pushed my change to my fork that supports Puppet 4.x and 5.x. The test ran cleanly on my machine (macOS) but they should run fine.