Possible bug in browser.js
shuslav opened this issue · comments
It seems the {{clientOptions}} should be surrounded with quotes?
var CLIENT_OPTIONS = '{{clientOptions}}'
yep, otherwise throw an error:
Error: Parsing file .../node_modules/racer-browserchannel/lib/browser.js: Line 4: Unexpected token
I think no. The line is correct.
Take a look at https://github.com/codeparty/racer-browserchannel/blob/master/lib/server.js#L24
Are you requiring this file directly? It is actually more of a template and
that placeholder is replaced as the file is browserified. Did this cause a
bug running the files for you or are you just identifying this reading the
code?
Would be nice if the extension indicated that the file is a template and
not js, but that would require passing extensions option to browserify and
makes the module harder to use for no good reason. It becomes proper is
during the browserify transform.
On May 29, 2014 7:27 AM, "Artur Zayats" notifications@github.com wrote:
Fell free to make a PR )
—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1#issuecomment-44537390
.
I fixed this here #3, it is a windows only issue.