Fix tests on Node.js 20
XhmikosR opened this issue · comments
Something changed in Node.js 20 and tests fail on main since a few months now.
If someone figures out why, please make a PR and CC me.
I have the same problem.
@XhmikosR which version of node it started?
Seems like it works with 20.4.0 but fail on 20.5.0
Maybe it's related to this change in 20.5.0
[986b46a567] - fs: add a fast-path for readFileSync utf-8 (Yagiz Nizipli) nodejs/node#48658
another relevant reference is here - kubernetes-client/javascript#1202
and also this one - tschaub/mock-fs#377
@GiladShoham yeah you are probably right. Unsure how to make tests pass again on Node.js 20. If you have any suggestions feel free to make a PR and CC me.
EDIT: I just looked at your linked PRs. It seems it's just a matter of calling toString('utf-8'). Anyway, feel free to make a PR.
I pushed a branch with debug enabled on CI and the issue seems to be with fs.existsSync:
- Node.js 18: https://github.com/dependents/node-dependency-tree/actions/runs/8565544868/job/23473747457
- Node.js 20: https://github.com/dependents/node-dependency-tree/actions/runs/8565544868/job/23473747584
Unsure how to proceed...
We are also hitting this in other repos like node-stylus-lookup:
- https://github.com/dependents/node-stylus-lookup/actions/runs/8565474632/job/23473580973
- https://github.com/dependents/node-stylus-lookup/actions/runs/8565474632/job/23473581057
EDIT: looks like it's a mock-fs issue? tschaub/mock-fs#377