dependabot / feedback

The old feedback repository for Dependabot. Click below for the new repository.

Home Page:https://github.com/dependabot/dependabot-core

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Default configuration does not pass Depandabot validation

merlinnot opened this issue · comments

Package manage/ecosystem

All.

Manifest contents prior to update

update_configs:
  - allowed_updates:
      - match:
          dependency_type: all
          update_type: security
      - match:
          dependency_type: direct
          update_type: all
    automerged_updates: []
    commit_message:
      include_scope: true
      prefix: chore
    default_assignees: []
    default_labels: []
    default_reviewers: []
    directory: /
    ignored_updates: []
    package_manager: javascript
    target_branch: master
    update_schedule: live
    version_requirement_updates: increase_versions
version: 1

Updated dependency

Not relevant.

What you expected to see, versus what you actually saw

In the configuration specified above, a few options fail validation:

automerged_updates: []
default_assignees: []
default_labels: []
default_reviewers: []
ignored_updates: []

For many of these an empty array is a default value.

When these options are specified explicitly, configuration does not pass validation, resulting in the following errors:

The property '#/update_configs/0/default_reviewers' did not contain a minimum number of items 1
The property '#/update_configs/0/default_assignees' did not contain a minimum number of items 1
The property '#/update_configs/0/default_labels' did not contain a minimum number of items 1
The property '#/update_configs/0/automerged_updates' did not contain a minimum number of items 1
The property '#/update_configs/0/ignored_updates' did not contain a minimum number of items 1

An expectation would be that default values (empty arrays) pass validation, since they are correct configuration options.

Images of the diff or a link to the PR, issue or logs

Not relevant.

commented

Hi @merlinnot, if you leave them out of the config it should work. I understand that the current behavior is confusing.

We're currently working on overhauling the config files and will take this feedback into consideration for the v2 syntax.

Yes, I know that it works when I leave it out, but sometimes I find it useful to make something explicit, so that others don't have to look into the documentation and remember what are the default values for certain configuration options, and know that they exist in the first place. I hope you'll make it possible in v2, thanks!