schedule regression
jsoref opened this issue · comments
https://github.com/dependabot/api-docs#user-content-create-an-update-config-for-a-repo
@dependabot appears to support:
| Attribute | Default | Description |
|---|---|---|
| update-schedule | None (required) | One of live, daily, weekly or monthly |
dependabot.com otoh supports:
When the dependabot migrator made pull requests to our repositories, it neglected to warn that this schedule detail was being discarded.
When the dependabot migrator made pull requests to our repositories, it neglected to warn that this schedule detail was being discarded.
@jsoref which option didn't get migrated? I would have expected the time to be migrated as it's not the default (05:00 UTC) but the weekday shouldn't as it's the default.
I have two repositories that show:
schedule:
interval: weekly
timezone: America/Toronto
And one:
schedule:
interval: weekly
day: wednesday
time: "07:00"
These commits were created by dependabot, not us...
@jsoref that looks right to me 👍 05:00 is the default time so is not included in the config file, the other config looks like it's from a different account as it has a different day and time set, but using the default utc timezone. Any of the following defaults won't be included in the config file:
- day:
monday - time:
05:00 - timezone:
utc
Is there an option that isn't the default, which also hasn't been included in the config file?
@feelepxyz: well, the linked api docs make no mention of time.
And all three of these are from the same account.
What we saw was PRs outside of our expected window, so I'm going off what I see and the API docs I see.
Oh sounds like a bug in that case, could you send over the account name and I can check what's happened?
The configuration options are listed here: https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#scheduletime
These api docs no longer apply to the new github-native version of dependabot and have been deprecated.
In that case, the docs should be updated to clearly indicate that at the top of each page (with a link to their replacement).
How do I send the account name? (GitHub is free to reach out to me directly)