denodrivers / postgres

PostgreSQL driver for Deno

Home Page:https://denodrivers.github.io/postgres

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Introduce a transpile safe check

cryptogohan opened this issue · comments

v. weird error. When using Deno run with --no-check it suddenly doesn't run anymore.

error: Uncaught SyntaxError: Unexpected token ';'
    _query: Query<ResultType.ARRAY>,
                                   ^
    at <anonymous> (https://raw.githubusercontent.com/denodrivers/postgres/master/client.ts:68:36)

All I could find was this issue:
MikaelPorttila/rss#23
denoland/deno#10684

Any idea what's going wrong?

As suggested by Kitsonk, this is likely cause by bad imports/exports in the library internals. I will probably introduce a CI step to typecheck and test (with no type check) separately

@Soremwar if this is still happening in --no-check mode then it's a big red flag that something is broken in Deno's transpilation pipeline. I think we could easily verify this in CI, but running a parallel step with --no-check argument, WDYT?

@bartlomieju I wonder if we can match these results by running deno test --no-check

I'll introduce a no check step right away, should be a good way to keep track of SWC problems

I wonder if we can match these results by running deno test --no-check

I'm not sure what you mean here @Soremwar?

The code that is breaking is running through deno run --no-check, so I'm not sure deno test --no-check will yield the same results

End result:

No-check failure is not gonna be terminal, however it will produce the following output that should make it easy to file an issue in Deno

image

Right now, deno-postgres should be no-check safe when running through deno test --no-check under Deno 1.16.0