Enable `clippy::string_slice`

[l]

This is similar to indexing_slicing which I clean up in #6214

We should enable it like this:

#![cfg_attr(not(test), warn(clippy::string_slice))]

And get rid of all potentially panicking slicing that is detected.